ENH: Make HDFStore iterable #12253
Closed
ENH: Make HDFStore iterable #12253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2016
Closed
| self.assertTrue(set( | ||
| store.keys()) == set(['/a', '/b', '/c', '/d', '/foo/bar'])) | ||
| expected = set(['/a', '/b', '/c', '/d', '/foo/bar']) | ||
| self.assertTrue(set(store.keys()) == expected) |
There was a problem hiding this comment.
pls add the tests from the original issue exactly (as a new test)
|
need a whatsnew |
toobaz
force-pushed
the
iterable_hdfstore
branch
from
5701d21 to
23bfb3a
Compare
|
@toobaz thanks! |
cldy
pushed a commit
to cldy/pandas
that referenced
this pull request
Feb 11, 2016
closes pandas-dev#12221 HDFStore is not an iterator - but being iterable, it can return an iterator of itself (i.e. of ``.keys()``). Author: Pietro Battiston <[email protected]> Closes pandas-dev#12253 from toobaz/iterable_hdfstore and squashes the following commits: 23bfb3a [Pietro Battiston] ENH: Make HDFStore iterable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12221
HDFStore is not an iterator - but being iterable, it can return an iterator of itself (i.e. of
.keys()).